Update logos #108
Merged
Update logos #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to new MPIMG logos.
Update molgen-logo.svg (extracted from molgen-logo-intern.svg with with Inkscape).
Update favicons (generated with favicon.io from provided file favicon-96x96.png.
As browserconfig.xml is not referenced from any other file in the repository, it and mstile-150x150.png where not used and I doubt someone wants it. AFAIK that was some legacy Internet Explorer stuff. Remove the files.
Update safari-pinned-tab.svg from povided file.
Two copies of favicon.ico exist in the repository. Use favicon/favicon.ico, remove images/favicon.ico.
|
Looks pretty and almost perfect! Even the icon in the backend is updated :) Since the new logo is much more lightweight overall and the writing is pretty small, I suggest we increase the height of the logo from 5rem to 7rem (line 116 in the costum.css) |
|
intranet2 shift-reload... |
|
Thank you. See, I'm just an amateur – there is something left. ;) It seems like the box around has to be increased in size, too (in order to prevent menu items to wander off into the white part of the page. navbar height +2 (line 125 in costum.css)
|
|
Very good. Wood have taken me ages to find that. Installed on intranet2 |
|
Looks good – I'd say go for it and push it to the live server :) |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ballaschk , please preview on https://intranet2.molgen.mpg.de
Note: Because Images and Icons are cached, you might need to use Shift-Reload to see the changes.